Remove calls to exit() from libavrdude library functions #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
With this PR Without this PR Above weird output is from a very recent git main, where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses a longstanding issue #774. Rather than using
exit(0)the latest git main already usesreturn LIBAVRDUDE_EXIT, but these return now need to be percolated to the top layer (main.cin the AVRDUDE application), which then shouldexit(0). Other applications built withlibavrdudemight want to stop the session without further errors. There is still a smattering ofexit(1)in thelibavrdudecode, but that is for really tricky situations where recovery is neigh impossible, for example when the process has run out of memory. To all intents and purposes this PR fixes #774.